Use fully qualified image names in docker-compose files #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modelmonster
force-pushed
the
fully-qualified-image-names
branch
from
17386e6 to
6ab1628
Compare
Member
|
Thanks! @tdruez ping ^ ? |
tdruez
requested changes
Apr 25, 2025
Contributor
tdruez
left a comment
tdruez
left a comment
There was a problem hiding this comment.
Changes look fine, except for the .env entry that should be removed.
| @if test -f ${ENV_FILE}; then echo ".env file exists already"; exit 1; fi | ||
| @mkdir -p $(shell dirname ${ENV_FILE}) && touch ${ENV_FILE} | ||
| @echo SECRET_KEY=\"${GET_SECRET_KEY}\" > ${ENV_FILE} | ||
| @echo COMPOSE_PROJECT_NAME=\"scancodeio\" >> ${ENV_FILE} |
Contributor
There was a problem hiding this comment.
This is the Django app .env file. The COMPOSE_PROJECT_NAME value does not seem relevant in that context.
Contributor
|
@modelmonster could you fix the DCO failure? |
…de-org#1376 (aboutcode-org#1636) Signed-off-by: tdruez <[email protected]> Signed-off-by: Model Monster <[email protected]>
Signed-off-by: tdruez <[email protected]> Signed-off-by: Model Monster <[email protected]>
Signed-off-by: tdruez <[email protected]> Signed-off-by: Model Monster <[email protected]>
Signed-off-by: Model Monster <[email protected]>
…ner naming Signed-off-by: Model Monster <[email protected]>
Signed-off-by: Model Monster <[email protected]>
modelmonster
force-pushed
the
fully-qualified-image-names
branch
from
6c8592f to
6e74f9f
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.